Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf file cleanup #10

Closed
wants to merge 2 commits into from
Closed

Protobuf file cleanup #10

wants to merge 2 commits into from

Conversation

bufdev
Copy link
Contributor

@bufdev bufdev commented Dec 19, 2015

This cleans up the example proto files a little:

This will conflict with #9, if you were to merge both, I'd prefer this branch merged first, and I can just redo the other one :)

Thoughts?

@jprobinson
Copy link
Contributor

We really appreciate your help, but prefer to keep the protobuf examples very basic so the users can concentrate on how Gizmo works. We'd also like to make sure we make minimal opinions about the protobuf toolset to keep the bar of adoption low.

@jprobinson jprobinson closed this Dec 21, 2015
@bufdev
Copy link
Contributor Author

bufdev commented Dec 21, 2015

That's fine, but I think you'd still want to do the repeated fields stuff.

@jprobinson
Copy link
Contributor

Good call. I've made the changes to rename results => result to match conventions: fcd5e32

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 39.882% when pulling cb2c4ae on peter-edge:protobuf_file_cleanup into 1747e0c on NYTimes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants