-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes gcp attributes accessible #114
Conversation
- Makes gcp.subscriber public - Makes gcp.subscribeImpl.sub public - Applies case changes to tests
- Makes subMessage public - Makes messageImpl's msg public - Channel runts SubMessage instead of interface
Unfortunately, this change breaks the interface contract on gizmo/pubsub.Subscriber:
Is there any way you can encapsulate the information you need inside the message payload? Perhaps an 'envelope'-like struct that holds metadata and the payload? |
Sorry, totally missed that. I'll take another stab at it. |
- Adds test for pubsub.Subscriber interface - Adds Attributes to SubMessage - Fills Attributes on Receive if msg is of type messageImpl - Allows for type conversion by external code on SubscriberMessage
Ok so i've changed back the interface part to External code can now use Also i've added a test to prevent future errors with the Please let me know if you see anything wrong with this, or any improvements. |
Ok, I think that's an acceptable workaround for folks who really need the attributes. Looks like we have some kind of merge conflict on this now. If you can clean that up, I'll pull this in. |
How can I see what the conflict is? The message under this pull-request shows there are no conflicts with the base branch? |
Ah, it just wouldn't let me 'rebase and merge'. Squashing and merging... |
🌮 thanks again! |
Just like my last pull request adding a function to Subscriber, this pull request adds a function to SubMessage making the underlying attributes sent with GCP accessible.