Pass golint for non-example packages #12
Conversation
| @@ -72,10 +74,12 @@ func (t *TestSubscriber) Start() <-chan pubsub.SubscriberMessage { | |||
| return msgs | |||
| } | |||
|
|
|||
| // Err ertuens the GivenErrError value. | |||
There was a problem hiding this comment.
A couple obvious spelling mistakes in here.
| @@ -234,10 +234,10 @@ func (s *TestSQSAPI) GetQueueAttributesRequest(*sqs.GetQueueAttributesInput) (*r | |||
| func (s *TestSQSAPI) GetQueueAttributes(*sqs.GetQueueAttributesInput) (*sqs.GetQueueAttributesOutput, error) { | |||
| return nil, errNotImpl | |||
| } | |||
| func (s *TestSQSAPI) GetQueueUrlRequest(*sqs.GetQueueUrlInput) (*request.Request, *sqs.GetQueueUrlOutput) { | |||
| func (s *TestSQSAPI) GetQueueURLRequest(*sqs.GetQueueURLInput) (*request.Request, *sqs.GetQueueUrlOutput) { | |||
There was a problem hiding this comment.
This makes golint pass, but actually breaks the code. AWS's library unfortunately generates names that do not match Go conventions 😞
https://godoc.org/github.com/aws/aws-sdk-go/service/sqs#GetQueueUrlInput
| server.HTTPPort = 80 | ||
| server.HTTPAccessLog = "LOG" | ||
| server.HealthCheckType = "PINGDOM" | ||
| portBound := server.PortBound() |
There was a problem hiding this comment.
It looks like you're missing the implementations of a few methods (PortBound, LogsPopulated, HealthCheckSet)
Not sure about adding these methods just to check for empty/nil values. It seems like it may add some unneeded misdirection, but I'll wait to see the full implementation before rejecting them.
There was a problem hiding this comment.
Sorry didn't mean to add them, was in another branch!
|
Just wanted to say thanks for the work you're doing! Very excited to see what you and the folks at The Economist come up with :) |
|
@jprobinson no hassles, we do use the Consul key-value store and parts (not all) of go-kit, and will be fascinated to see if gizmo fits into our picture. |
| @@ -8,7 +8,7 @@ import ( | |||
| ) | |||
|
|
|||
| type ( | |||
| // TestPublisher is a simple implementation of pubsub.Publisher meant to | |||
| // TestSubscriber is a simple implementation of pubsub.Publisher meant to | |||
There was a problem hiding this comment.
Fixed the name, but still has a bad doc. I'll fix it in master.
|
thanks! 😸 |
Pass golint for non-example packages
|
@jprobinson no worries, will have a deeper dig now! |
All the non-example packages now pass golint, hope this helps!
The code under the examples folder needs more detailed attention, happy to assist. Love this, we are building out microservices at The Economist and it's fascinating to see what's going on. Here are a couple of our open source repos:
https://github.com/EconomistDigitalSolutions/ramlapi
https://github.com/EconomistDigitalSolutions/goberry
...more to come!