Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server/kit] filtering out expected shutdown errors & capturing test errors properly #126

Merged
merged 2 commits into from
Sep 21, 2017
Merged

[server/kit] filtering out expected shutdown errors & capturing test errors properly #126

merged 2 commits into from
Sep 21, 2017

Conversation

jprobinson
Copy link
Contributor

This is my attempt at resolving the problems discussed in #125 without adding channels to the server.

@alrs, how do you feel about these changes?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 46.83% when pulling f772edf on kitserver-shutdown-errors into 8a49dc4 on master.

@jprobinson jprobinson merged commit 87bdc39 into master Sep 21, 2017
@jprobinson jprobinson mentioned this pull request Sep 21, 2017
Closed
@jprobinson jprobinson deleted the kitserver-shutdown-errors branch September 21, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

@oliver-nyt oliver-nyt oliver-nyt approved these changes

@darrenmcc darrenmcc Awaiting requested review from darrenmcc

@gaplyk gaplyk Awaiting requested review from gaplyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jprobinson @coveralls @fsouza @oliver-nyt