Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default handler for 404 metrics to '__404__' #145

Merged
merged 1 commit into from
Jun 4, 2018
Merged

default handler for 404 metrics to '__404__' #145

merged 1 commit into from
Jun 4, 2018

Conversation

oliver-nyt
Copy link
Contributor

To address #144

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 46.194% when pulling 9135629 on oliver-nyt:oh_fix_404_metrics into bec4a80 on NYTimes:master.

jprobinson
jprobinson approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@jprobinson jprobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌯 🚯

@jprobinson jprobinson merged commit 298b6ae into nytimes:master Jun 4, 2018
@oliver-nyt
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprobinson jprobinson jprobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliver-nyt @coveralls @jprobinson