Allow overriding of AWS endpoint #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS service endpoint can be overridden to enable emulation. For example by using localstack.
jprobinson
suggested changes
Oct 16, 2018
There was a problem hiding this comment.
Thanks for adding this, @surajbarkale!
I've requests a couple small changes, let me know if you have any problems.
Also, it looks like we were hit by the golint URL move. I've updated master to fix things but TravisCI is still failing on this PR. Mind pulling from master to get the fixes?
jprobinson
approved these changes
Oct 18, 2018
|
thanks again, @surajbarkale! 🌯! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS service endpoint can be overridden to enable emulation. For example by using localstack. Fixes #156