Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up underused and non-recommended code #171

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Conversation

jprobinson
Copy link
Contributor

Some of the under-used features of Gizmo and the additional dependencies they bring in tends to be one of the things that keeps me up at night.

This PR will bring some breaking changes, but the hope is to cut down on our dependency footprint and hone the scope of the toolkit.

Work so far:

web package is gone, important bits are pulled into server
config/combined, config/cookie, config/gcp, config/oracle and config/mongodb are gone (let me know if you really need the latter two)
config.LoadEnvConfig is gone as it was just a thin wrapper around envconfig.Process
server.RPCServer is gone
server.ESXHealthCheck is gone
• references to appengine in server are gone

@coveralls
Copy link

coveralls commented Dec 19, 2018

Coverage Status

Coverage increased (+2.8%) to 45.822% when pulling 2019f79 on clean-up into c66e686 on master.

@jprobinson jprobinson changed the title [WIP] Cleaning up underused and non-recommended code Cleaning up underused and non-recommended code Jan 2, 2019
@jprobinson jprobinson merged commit 22091b3 into master Jan 2, 2019
@jprobinson jprobinson deleted the clean-up branch January 2, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants