Cleaning up underused and non-recommended code #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the under-used features of Gizmo and the additional dependencies they bring in tends to be one of the things that keeps me up at night.
This PR will bring some breaking changes, but the hope is to cut down on our dependency footprint and hone the scope of the toolkit.
Work so far:
•
web
package is gone, important bits are pulled intoserver
•
config/combined
,config/cookie
,config/gcp
,config/oracle
andconfig/mongodb
are gone (let me know if you really need the latter two)•
config.LoadEnvConfig
is gone as it was just a thin wrapper aroundenvconfig.Process
•
server.RPCServer
is gone•
server.ESXHealthCheck
is gone• references to
appengine
inserver
are gone