-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Deprecated Fast Router #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Marwan! Should we also remove it from the mod file?
Tidy up |
@fsouza @jprobinson "go mod tidy" does not change anything, it's probably because |
:cries: |
Dang, I thought I had removed it from there but it was just If you don't mind, let's rid ourselves of that package for good and remove it from the kit server as well? |
@@ -28,7 +28,6 @@ require ( | |||
github.com/gorilla/mux v1.7.0 | |||
github.com/gorilla/websocket v1.4.0 | |||
github.com/grpc-ecosystem/go-grpc-middleware v1.0.0 | |||
github.com/julienschmidt/httprouter v1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 yay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌯 !!! thanks @marwan-at-work!
Fixes #190 ✌️