Renaming ConsumeProtobuf to ConsumeBase64 and defaulting to 'true'
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making it default to true fixing tests
jprobinson
added a commit
that referenced
this pull request
Feb 10, 2016
Renaming `ConsumeProtobuf` to `ConsumeBase64` and defaulting to 'true'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the SNS publisher base64 encodes the payload. On the SQS side, base64 decoding was not the default and the current version will only base64 decode if the
config.SQS.ConsumeProtobufflag was set.To make the SQS subscriber's default compatible with SNS publisher's default, this will change that flag to be "true" by default.
Also, to better reflect what the flag is used for, I've renamed it from
ConsumeProtobuftoConsumeBase64.