Fix memory leak in ContextSerivce. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // WithCloseHandler returns a Handler cancelling the context when the client | ||
| // connection close unexpectedly. | ||
| func WithCloseHandler(h ContextHandler) ContextHandler { |
There was a problem hiding this comment.
Are you calling this anywhere? Or just bringing the function into the toolkit?
There was a problem hiding this comment.
Instead of copy/paste straight from rs/xhandler, could you just use their xhandler.CloseHandler instead?
There was a problem hiding this comment.
do we need to use additional library? and we have different types.
Just tried - we could not use
There was a problem hiding this comment.
Ah, I thought they interface was compatible, but since we have a ServeHTTPContext where they have ServeHTTPC, you're right that it's not an easy drop-in.
Go ahead and leave this for now.
|
Looks good! Thanks, @gaplyk! |
jprobinson
added a commit
that referenced
this pull request
Mar 10, 2016
Fix memory leak in ContextSerivce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make context.Background for each request to the server. (When it's global, this cause memory leak)
Remove ContextWithIP and ContextWithForwardForIP. Could be used in ContextMiddleware
Add WithCloseHandler middleware