Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching underlying metrics provider from rcrowley/go-metrics to go-kit/kit/metrics #59

Merged
merged 5 commits into from
May 24, 2016

Conversation

jprobinson
Copy link
Contributor

@jprobinson jprobinson commented May 19, 2016

  • config.Server.GraphiteHost is now a deprecated config.
  • New config.Metrics, config.Config.Metrics and config.Server.Metrics handle all metrics configuration.
  • Now able to integrate with statsd, dogstatsd, prometheus, expvar, graphite or nothing at all.
  • Changes to emitted server route metric names:
    • Counter names no longer have a .count suffix
    • Histogram quantile names change from suffixes like 50-percentile to _50p

@coveralls
Copy link

coveralls commented May 23, 2016

Coverage Status

Coverage decreased (-0.6%) to 44.966% when pulling 31fdbe0 on kit-metrics into 5761566 on master.

@coveralls
Copy link

coveralls commented May 23, 2016

Coverage Status

Coverage increased (+0.4%) to 45.966% when pulling abcca4e on kit-metrics into 5761566 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants