Skip to content

Commit

Permalink
preparing 0.5.0 release
Browse files Browse the repository at this point in the history
  • Loading branch information
delambo committed Dec 6, 2013
1 parent cda1d4d commit 2258350
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 21 deletions.
9 changes: 6 additions & 3 deletions Gruntfile.js
Expand Up @@ -55,6 +55,9 @@ module.exports = function(grunt) {

uglify: {
options: {
beautify : {
ascii_only : true
} ,
preserveComments: false,
banner: '//\n' +
'// <%= pkg.name %> - v<%= pkg.version %>\n' +
Expand All @@ -64,7 +67,7 @@ module.exports = function(grunt) {
},
ice: {
files: {
'dist/ice.min.js': ['lib/rangy/rangy-core.js', 'src/polyfills.js', 'src/ice.js', 'src/dom.js', 'src/bookmark.js', 'src/selection.js', 'src/icePlugin.js', 'src/icePluginManager.js', 'src/plugins/IceAddTitlePlugin/IceAddTitlePlugin.js', 'src/plugins/IceCopyPastePlugin/IceCopyPastePlugin.js', 'src/plugins/IceSmartQuotesPlugin/IceSmartQuotesPlugin.js', 'src/plugins/IceEmdashPlugin/IceEmdashPlugin.js']
'dist/ice.min.js': ['dist/ice.js']
}
},
icemaster: {
Expand All @@ -76,7 +79,7 @@ module.exports = function(grunt) {
'//\n'
},
files: {
'ice-master.min.js': ['lib/rangy/rangy-core.js', 'src/polyfills.js', 'src/ice.js', 'src/dom.js', 'src/bookmark.js', 'src/selection.js', 'src/icePlugin.js', 'src/icePluginManager.js', 'src/plugins/IceAddTitlePlugin/IceAddTitlePlugin.js', 'src/plugins/IceCopyPastePlugin/IceCopyPastePlugin.js', 'src/plugins/IceSmartQuotesPlugin/IceSmartQuotesPlugin.js', 'src/plugins/IceEmdashPlugin/IceEmdashPlugin.js']
'ice-master.min.js': ['dist/ice.js']
}
},
tinyice: {
Expand Down Expand Up @@ -125,7 +128,7 @@ module.exports = function(grunt) {

grunt.registerTask('test', ['connect', 'qunit']);

grunt.registerTask('build', ['clean:build', 'uglify:ice', 'uglify:icemaster', 'concat', 'compress:gz', 'cp', 'compress:zip']);
grunt.registerTask('build', ['clean:build', 'concat', 'uglify:ice', 'uglify:icemaster', 'compress:gz', 'cp', 'compress:zip']);

grunt.registerTask('cp', function() {
cpTinyDir('ice');
Expand Down
24 changes: 14 additions & 10 deletions README.md
@@ -1,14 +1,14 @@
# ice.js

Ice is a track changes implementation, built in javascript, for anything that is `contenteditable` on the web. Conceived by the CMS Group at The New York Times, ice has been piloting successfully for articles written in the newsroom.
Ice is a track changes implementation, built in javascript, for anything that is `contenteditable` on the web. Conceived by the CMS Group at The New York Times, ice is powering the editor used for articles written in the newsroom.

## Demo

[Check it out!](http://NYTimes.github.com/ice/demo/)
[Try it](http://NYTimes.github.com/ice/demo/)

## Download

[v0.4.2](http://nytimes.github.com/ice/downloads/ice_0.4.2.zip)
[v0.5.0](http://nytimes.github.com/ice/downloads/ice_0.5.0.zip)

## Features

Expand Down Expand Up @@ -111,17 +111,21 @@ Additional options:
```
***

**_Wordpress initialization_**
## Limitations/Dependencies

In testing - more to come soon.
- ice needs to be initialized after the DOM ready event fires.
- Wordpress support is limited. We need contribution from any willing WordPress developers.
- Browser support is limited to Firefox (5+) and Webkit browsers, and minimal support for IE8+.

***
## Changelog

## Limitations/Dependencies
### Master
- *up to date*

- ice needs to be initialized after the DOM ready event fires.
- ice was originally created for the simple markup behind nytimes.com articles (`p`, `a`, `em`, `strong`). As such, it requires that all text editing takes place in a common root block element, and that there are no other blocks found in the editor. Any type of inline elements are ok, inside of the common root blocks.
- Unfortunately, we haven't been able to test this across all browsers and versions. We know that it tests well in modern Firefox (5+) and Webkit browsers, and "seems to work" in IE7+. We intend to do more testing and get a better idea about what ice can support across browsers.
### 0.5.0

- Fixes cut, copy, paste for Firefox and Webkit browsers.
- Fixes delete tracking in webkit browsers.

## License

Expand Down
8 changes: 4 additions & 4 deletions ice-master.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
@@ -1,7 +1,7 @@
{
"name": "ice",
"description": "Track changes in JavaScript.",
"version": "0.4.1",
"version": "0.5.0",
"author": "Matthew DeLambo <delambo@gmail.com>",
"repository": {
"type": "git",
Expand All @@ -13,7 +13,7 @@
"grunt-contrib-concat": "~0.1.3",
"grunt-contrib-jshint": "~0.2.0",
"grunt-contrib-qunit": "~0.2.0",
"grunt-contrib-uglify": "~0.1.2",
"grunt-contrib-uglify": "~0.2.7",
"grunt-contrib-clean": "~0.4.0",
"grunt-contrib-compress": "~0.5.2",
"grunt-contrib-connect": "~0.2.0"
Expand Down
4 changes: 2 additions & 2 deletions src/dom.js
Expand Up @@ -135,14 +135,14 @@
frag.appendChild(child);
}
return frag;
},
};

/**
* Returns this `node` or the first parent tracking node that matches the given `selector`.
*/
dom.getNode = function (node, selector) {
return dom.is(node, selector) ? node : dom.parents(node, selector)[0] || null;
},
};

dom.getParents = function (elements, filter, stopEl) {
var res = jQuery(elements).parents(filter);
Expand Down

0 comments on commit 2258350

Please sign in to comment.