New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More preparation for iOS videos integration #7
Conversation
_videoNode.position = CGPointMake(scene.size.width / 2, scene.size.height / 2); | ||
_videoNode.size = scene.size; | ||
_videoNode.yScale = -1; | ||
_videoNode.xScale = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this "child object" initialization, can you please mimic the "scoped object creation & configuration" patter used to create the skScene
?
This looks good to me overall. I would only suggest that the |
LGTM, one question, does controlling the the |
That has never worked. The |
@jaredsinclair 👍 once merge conflict is resolved |
The primary goal was to add
play
andpause
methods to NYT360VideoViewController. This required some new methods and properties in other classes to make it work. I also cleaned up some files I encountered to make the method groupings and variable names easier to follow.