Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow renderable with content. #95

Merged
merged 5 commits into from Aug 15, 2018
Merged

Conversation

jbenden
Copy link
Contributor

@jbenden jbenden commented Aug 12, 2018

This patch permits the with option, of tasks, to contain
Jinja2 renderable content. This is useful when the models
section contains data to be reused across a number of tasks.

This patch permits the `with` option, of `tasks`, to contain
Jinja2 renderable content. This is useful when the `models`
section contains data to be reused across a number of `tasks`.
@Nachtfeuer
Copy link
Owner

Like it. Will Check soon. I‘m looking forward to rollout it together with current milestone. Also I will add that to the documentation.

@coveralls
Copy link

coveralls commented Aug 12, 2018

Coverage Status

Coverage increased (+0.02%) to 97.139% when pulling 7c51b6b on jbenden:rendered-with into 2e1aa3d on Nachtfeuer:master.

@jbenden
Copy link
Contributor Author

jbenden commented Aug 13, 2018

It seems that CI failed to run for reasons that may not be because of coding errors. Any help would be greatly appreciated, to accelerate acceptance of this change.

@Nachtfeuer
Copy link
Owner

Nachtfeuer commented Aug 14, 2018

Mmhhh ... from two failing builds the one has failed by downloading the base system. I restartet it. But Python 3.6 has failed because of this:

Traceback (most recent call last):
  File "/home/travis/build/Nachtfeuer/pipeline/tests/components/test_docker_container.py", line 28, in test_creator_complete
    assert_that(len(output), equal_to(1))
AssertionError: 
Expected: <1>
     but: was <0>

Could you please have a look at that?

@jbenden
Copy link
Contributor Author

jbenden commented Aug 14, 2018

I had been experiencing this failing test, previous to the myriad of PRs I've created. I suspect that one of them in fact solves the problems seen here.

@Nachtfeuer Nachtfeuer merged commit 11fdf0b into Nachtfeuer:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants