Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "react-sortable-hoc" to avoid incorrect peer dependency #70

Closed
mhouel opened this issue Apr 8, 2021 · 2 comments
Closed

Update "react-sortable-hoc" to avoid incorrect peer dependency #70

mhouel opened this issue Apr 8, 2021 · 2 comments

Comments

@mhouel
Copy link

mhouel commented Apr 8, 2021

Hi,

The project has a peer dependency with React 17, and a dependency with React Grid Table 1.1.
That plugin has a peer dependency with React 14 || 15 || 16, and thus, trigger an incorrect peer dependency warning :

warning "@nadavshaar/react-grid-table > react-sortable-hoc@1.11.0" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".
warning "@nadavshaar/react-grid-table > react-sortable-hoc@1.11.0" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0 || ^16.0.0".

They published a 2.0 version just 20 days ago, compatible with React 17.
Would it be possible to update the dependency ? or maybe change the project peerDependencies ?
Thanks !

@NadavShaar
Copy link
Owner

Thanks a lot, will update the package soon.

@NadavShaar
Copy link
Owner

Fixed in version 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants