Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

01 - Display important details of a single entry #1

Closed
13 tasks done
NadineGrosskreuz opened this issue May 5, 2022 · 1 comment
Closed
13 tasks done

01 - Display important details of a single entry #1

NadineGrosskreuz opened this issue May 5, 2022 · 1 comment

Comments

@NadineGrosskreuz
Copy link
Owner

NadineGrosskreuz commented May 5, 2022

Value Proposition

As a user
I need to see an flea market/shop
to be able to get the information about the flea market/shop I am interested in.

Description

Scribble / design or text
Single entry

Acceptance Criteria

  • The entry's category is displayed
  • The flea market's/shop's name is displayed
  • The flea market's/shop's location is displayed

Tasks

  • Create the data structure to hold the entry details
  • Create a new component to render the data in a <h2> and <p> tag
  • The component receives entry details via props
  • Add component to the app
  • Add styled-components
  • Add to Storybook
  • Add test to check if data is rendered
  • Check accessibility
  • Deploy for usability and UX testing
  • Check on mobile phone

Complexity

M

@NadineGrosskreuz NadineGrosskreuz changed the title Display important details of a single entry 01 - Display important details of a single entry May 9, 2022
This was referenced May 9, 2022
@julialoeschel
Copy link

Hello,
good first story, I have some suggestions for you:

  • If you set up data that is more than one entry, you may want to render a list of cards here already.
  • to do so, your wireframe may include the whole screen, not just one card.
  • also if you are scribbeling, try using "real" data, so get a clue about spacing and size of content.
  • your Value Preposition is a little unspecific. Think about a real benefit for the use. I suggest smth like: "...I need to see a list of flew markets, to be able to get the information about the markets available. "
  • The following tasks are not necessary to mention in your Tats-list:
    • Create a new branch "display-entry" (please always do that!)
    • ...to render the data in a p tag (we are not giving information about the "how" here)
    • The component receives entry details via props (same)
    • Apply basic styling (is usually always included)
    • ...to check if data is rendered (unnecessary information here)

This seems like a lot, dont worry.
The story is good, these are suggestions to make it even better ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants