Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for angular AOT #5

Closed
ahmed-musallam opened this issue Apr 2, 2017 · 6 comments
Closed

support for angular AOT #5

ahmed-musallam opened this issue Apr 2, 2017 · 6 comments

Comments

@ahmed-musallam
Copy link

Hi, there was a question on stackoverflow that I answered where this directive does not work with AOT. Please see my answer to the question if you'd like to make this directive compatible with AOT.

http://stackoverflow.com/questions/43166491/angular2-build-under-angular-cli-with-directive-and-ng-build-prod/43172360?noredirect=1#comment73418872_43172360

I'd also say, you should probably expose the source TS file alongside the generated JS file in the published package. In a new release of course.

@seiyria
Copy link
Contributor

seiyria commented Jun 19, 2017

Please do this, I don't like pulling dependencies in manually!

@NagRock
Copy link
Owner

NagRock commented Jun 19, 2017

@seiyria maybe You want to contribute with this?

@seiyria
Copy link
Contributor

seiyria commented Jun 19, 2017

@NagRock see #7

@beradrian
Copy link
Contributor

Is there any plan to fix this issue?

NagRock added a commit that referenced this issue Jan 16, 2018
change module to es6 to support aot, #5
@beradrian
Copy link
Contributor

I guess this issue can be closed now, right?

@NagRock
Copy link
Owner

NagRock commented Feb 1, 2018

Done in 1.1.0 version.

@NagRock NagRock closed this as completed Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants