Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No retry on incompleted downloads? #1206

Closed
3 tasks done
mugi-jiichan opened this issue Dec 13, 2022 · 4 comments
Closed
3 tasks done

No retry on incompleted downloads? #1206

mugi-jiichan opened this issue Dec 13, 2022 · 4 comments

Comments

@mugi-jiichan
Copy link

Prerequisites

Description

I've noticed that PU2 seems to ignore the config.ini retry entries, so it doesn't retry to download an incompleted file. Instead, the *.pixiv file is simply deleted while download is continued with the next file on the list.

This occurs for me with all download modes, but I mainly use downloads through modes 1, 3, 5, 7, and 10.

I've attached config.ini and pixivutil2.log.

Steps to Reproduce

  1. Start download cue.
  2. Have a short network timeout. (Pull the cable and put it back into the socket, or go to and undo flight mode for example)
  3. [and so on...]

Expected behavior:
Retry download as specified in config.ini (in this case, 5 retries with a break of 15 seconds).

Actual behavior:
Incompleted download is deleted, PU2 continues with the next download.

Log file: [Attach the pixivutil.log file in the application folder, recommended to delete the old file, reproduce the issue, and upload the newly generated file here]

Versions

20221029 (cloned source to disk from master repository on Dec 8th to test #1191 )
config.ini.txt
pixivutil.log

@Nandaka
Copy link
Owner

Nandaka commented Dec 15, 2022

weird, it does retry and download the image correctly.
image
image

@Nandaka
Copy link
Owner

Nandaka commented Dec 15, 2022

hmm, I might found the cause due to #1201
need to recheck if the file successfully downloaded

@NewUserHa
Copy link
Contributor

NewUserHa commented Dec 15, 2022

Does version 20221029 have this issue? It should also have this issue.

@Nandaka
Copy link
Owner

Nandaka commented Dec 16, 2022

it is a bit of combination of and existing issue, somehow timeout error is skipping the retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants