Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/settings #84

Merged
merged 3 commits into from Jul 24, 2020
Merged

Fix/settings #84

merged 3 commits into from Jul 24, 2020

Conversation

Frenchcooc
Copy link
Contributor

Description

Improve how we display errors (in HTML), with a new directory and structure:

views/errors
 |- 400.ejs    
 |- 401.ejs
 |- 404.ejs
 |- 500.ejs
 |- layout.ejs

Also fixed an issue with rendering of environment variables. Now showing the first 5 chars. Not the last 4 chars.

 -  <span><%= (key.value || '').slice(-4) + '*'.repeat(15) %> </span>
 +  <span><%= (key.value || '').slice(0, 5) + '*'.repeat(15) %> </span>

@Frenchcooc Frenchcooc merged commit 74f6528 into master Jul 24, 2020
@Frenchcooc Frenchcooc deleted the fix/settings branch July 24, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Frenchcooc