Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand rankers to work with dq results #297

Merged
merged 3 commits into from
Jun 6, 2023
Merged

expand rankers to work with dq results #297

merged 3 commits into from
Jun 6, 2023

Conversation

nikml
Copy link
Contributor

@nikml nikml commented May 26, 2023

No description provided.

@nikml nikml self-assigned this May 26, 2023
@nikml nikml requested a review from nnansters as a code owner May 26, 2023 20:56
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 88.23% and project coverage change: -0.20 ⚠️

Comparison is base (ce4fc18) 83.16% compared to head (fd62811) 82.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   83.16%   82.96%   -0.20%     
==========================================
  Files          82       82              
  Lines        6408     6353      -55     
  Branches      971      959      -12     
==========================================
- Hits         5329     5271      -58     
- Misses        819      821       +2     
- Partials      260      261       +1     
Impacted Files Coverage Δ
nannyml/drift/ranker.py 91.34% <88.23%> (-2.14%) ⬇️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Niels Nuyttens <niels@nannyml.com>
Signed-off-by: Niels Nuyttens <niels@nannyml.com>
@nnansters nnansters merged commit 7a9e81e into main Jun 6, 2023
5 of 7 checks passed
@nnansters nnansters deleted the fix_dq_ranking1 branch June 6, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants