Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arg (propagation) issues with result classes #298

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

nikml
Copy link
Contributor

@nikml nikml commented May 31, 2023

No description provided.

@nikml nikml requested a review from nnansters as a code owner May 31, 2023 19:51
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.11 ⚠️

Comparison is base (ce4fc18) 83.16% compared to head (05b9158) 83.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   83.16%   83.05%   -0.11%     
==========================================
  Files          82       82              
  Lines        6408     6398      -10     
  Branches      971      956      -15     
==========================================
- Hits         5329     5314      -15     
- Misses        819      824       +5     
  Partials      260      260              
Impacted Files Coverage Δ
nannyml/io/store/serializers.py 48.88% <0.00%> (ø)
nannyml/base.py 81.66% <100.00%> (ø)
nannyml/drift/univariate/result.py 93.42% <100.00%> (ø)
nannyml/performance_calculation/result.py 77.19% <100.00%> (-1.76%) ⬇️
...performance_estimation/confidence_based/results.py 96.42% <100.00%> (-3.58%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nnansters nnansters merged commit 00c7640 into main Jun 5, 2023
1 of 7 checks passed
@nnansters nnansters deleted the result_args_fix branch June 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants