Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison plot titles #305

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix comparison plot titles #305

merged 1 commit into from
Jun 8, 2023

Conversation

michael-nml
Copy link
Collaborator

@michael-nml michael-nml commented Jun 7, 2023

Fixes an issue for comparison plot titles introduced by changes to the display name in #289.

Before fix:
comparison_plot_title_error

After fix:
comparison_plot_fixed

Fixes an issue introduced by changes to the display name in
aaee229.
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (6b207ea) 83.22% compared to head (8d61bda) 83.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   83.22%   83.17%   -0.05%     
==========================================
  Files          82       82              
  Lines        6431     6431              
  Branches      974      974              
==========================================
- Hits         5352     5349       -3     
- Misses        818      819       +1     
- Partials      261      263       +2     
Impacted Files Coverage Δ
nannyml/plots/blueprints/comparisons.py 83.76% <0.00%> (-1.58%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nnansters nnansters merged commit 759ec03 into main Jun 8, 2023
4 of 7 checks passed
@nnansters nnansters deleted the fix/comparison-plot-titles branch June 8, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants