Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unit test for adjoint gradients in 3D #2661

Open
oskooi opened this issue Oct 3, 2023 · 2 comments
Open

Missing unit test for adjoint gradients in 3D #2661

oskooi opened this issue Oct 3, 2023 · 2 comments

Comments

@oskooi
Copy link
Collaborator

oskooi commented Oct 3, 2023

Currently, all of the unit tests for the adjoint gradients in test_adjoint_solver.py are based on a 2D simulation. Even though we have used the adjoint solver for 3D simulations (e.g., optimizing 2D gratings), there are no such unit tests.

The 3D tests should check two different configurations of the design region via the MaterialGrid:

  1. a 2D topology in the $xy$ plane which is extruded in $z$ such as a cylinder.
  2. a fully 3D topology such as a sphere or cuboid.

We should also test the single and multifrequency case. For the latter, we should test narrow and broad bandwidths (similar to #2307).

Given the generally larger size and runtime of 3D tests, we may want to separate these tests from the existing suite in make check.

@stevengj
Copy link
Collaborator

stevengj commented Oct 5, 2023

A quicker test of essentially the same functionality would be a 2d calculation with a 1d material grid.

@MarkMa1990
Copy link

looking forward to have such test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants