Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python quiet function #876

Merged
merged 2 commits into from May 23, 2019
Merged

Add Python quiet function #876

merged 2 commits into from May 23, 2019

Conversation

ChristopherHogan
Copy link
Contributor

Closes #874.

@stevengj stevengj merged commit e3e397c into NanoComp:master May 23, 2019
@ChristopherHogan ChristopherHogan deleted the chogan/quiet branch May 24, 2019 14:08
@klein-j
Copy link

klein-j commented Jun 18, 2019

I like the idea of this patch, but I don't think it is going far enough. The amount of lines printed by meep where only reduced by about 20% in my program. The selection is also pretty unintuitive. "Field time usage" is omitted, but "Meep: using complex fields." or "Working in 1D dimensions" is still shown. Those are very particular and fine grained information that I am usually aware of rather than some sort of warnings. I don't see why those would still be displayed in silent mode.

In short I think it would be nice to silence all output (and even better if multiple levels of log details would be configurable).

bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
* Add Python quiet function

* Update quiet docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose/document quiet
4 participants