Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anybody else having issues? #86

Closed
eddelbuettel opened this issue Feb 5, 2021 · 7 comments
Closed

Anybody else having issues? #86

eddelbuettel opened this issue Feb 5, 2021 · 7 comments

Comments

@eddelbuettel
Copy link

Did GitHub change something (again)? When enabled all I get is this at the top

image

and nothing at the bottom:

image

So having the extension 'swallows' their display which shows total count over last year (and nothing else):

image

@Naramsim
Copy link
Owner

Naramsim commented Feb 5, 2021

Yep, I confirm. Probably they changed the DOM. I'll look into it tomorrow.

@ian-pvd
Copy link

ian-pvd commented Feb 6, 2021

Looks like an issue here:
Screen Shot 2021-02-05 at 21 02 59

just glanced under the hood but might need to change document.getElementsByClassName('day') => document.getElementsByClassName('ContributionCalendar-day') ? Idk, I'm not looking at source.

Screen Shot 2021-02-05 at 21 07 33

(thank you)

@Naramsim
Copy link
Owner

Naramsim commented Feb 6, 2021

@ian-pvd, almost got it :)

It was

document.querySelectorAll('.ContributionCalendar-day[data-count]');

@Naramsim
Copy link
Owner

Naramsim commented Feb 7, 2021

Chrome already made the new version public. I also submitted it to the FF addons marketplace.

@eddelbuettel
Copy link
Author

I see it in the Chrome app store, my instance is still at the old one. I'll just wait a bit.

Thanks so much as always!

@ljharb
Copy link

ljharb commented Feb 7, 2021

After updating and restarting Chrome, today's extension update seems to be working again. Thank you!

@eddelbuettel
Copy link
Author

Back up now to working as usual. Magic. Yay. 🍰 Many thanks for looking into it.

I'll close it as we're thankfully back to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants