Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tac Life Support Auto-Balance #144

Closed
arsenictonic opened this issue May 7, 2016 · 7 comments
Closed

Tac Life Support Auto-Balance #144

arsenictonic opened this issue May 7, 2016 · 7 comments
Labels
Back Burner Low priority or needs further consideration QoL Quality of Life issue.

Comments

@arsenictonic
Copy link

Add a function that allows autofill with correct portions of food/oxygen/water.

@Gordon-Dry
Copy link

Oh my ...

I tried to create a generic patch that does this the last days.

I came to the following conclusion:

My patch works by now, but...

When I pre-fill a TANK and then delete the stock !RESOURCE afterwards, the TANK is empty in VAB/SPC.
But in ModuleManager.ConfigCache it's stated clearly:
The TANK is filled.

@Gordon-Dry
Copy link

Gordon-Dry commented Aug 6, 2017

I would much appreciate (when TAC-LS is installed) a button in the context menu (VAB/SPH) of any part that is

  • crewable
  • has ModuleFuelTanks type = ServiceModule
  • does not already have prefilled TAC-LS resources*

to autofill the remaining ModuleFuelTanks volume with TAC-LS resources in a balanced way.
This includes the empty tanks for waste, so the maxAmount.

*ofc when all resources are removed than the button should be available again.
Then all resources could be removed, some other resources can be added (like RCS, more EC etc.) and then finally add the proper balanced TAC-LS resources to fill the tanks.

Think about it like when an engine is present, the tanks can be filled with the proper fuel (mixture).
The same should be possible with TAC-LS life support, but not only when a crew is present (like for service modules).

That would be much better than trying to create a patch that has to fight with other patches which use FINAL.

The only thing that should be done by the creators of parts then would be adding volume to the ModuleFuelTanks that fits the max. amount of needed TAC-LS resources. This fact should be mentioned in the README then and also forwarded to JPLRepo to mention it in the README of TAC-LS as well.

@Bornholio
Copy link

we had a little "engine " part in RP0 dev for a while that did this. placed it, filled tanks then removed it.

@NathanKell
Copy link
Member

NathanKell commented Jan 12, 2019 via email

@glilienthal
Copy link

Could it be added to the MF code so that it seems as if such an engine is always there?

However it is solved, this feature would be really great!

@Starwaster Starwaster added Back Burner Low priority or needs further consideration QoL Quality of Life issue. labels Aug 6, 2019
@Starwaster
Copy link
Contributor

While there are no code changes planned that would allow for automatic tank configuration, I would like to point out #218 which has been implemented. Look at the linked issue to see how to configure the part with resources that cannot be emptied by MFS or RF. If you add an UNMANAGED_RESOURCE that quantity will stay there. You can add tanks that contain more of it but the original quantity will always be there even if you later 'Remove All Tanks'

Closing this for now. It has the back burner label so maybe at a future date it might be revisited.

@siimav
Copy link
Collaborator

siimav commented Aug 6, 2019

Actually Pap already added a life support engine into RO that works perfectly for getting the right resource proportions.
https://github.com/KSP-RO/RealismOverhaul/blob/4123530773edaead0b7478ab7b1e978546978425/GameData/RealismOverhaul/RO_RecommendedMods/TACLS/RO_TACLS_FakeEngine.cfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back Burner Low priority or needs further consideration QoL Quality of Life issue.
Projects
None yet
Development

No branches or pull requests

7 participants