Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Very old Android implementation: lib does not pass the 'Sec-WebSocket-Protocol' header #35

Closed
soulfly opened this issue Dec 14, 2017 · 4 comments

Comments

@soulfly
Copy link
Contributor

soulfly commented Dec 14, 2017

I see you use very old version of java_websocket.jar and hence this nativescript-websockets lib has some issues

  1. You use the Draft_17 here
    https://github.com/NathanaelA/nativescript-websockets/blob/master/websockets.android.js#L223

hence this._protocol is just ignored

as a result, my server does not receive the Sec-WebSocket-Protocol header and returns an error

  1. There is already the Draft_6455

https://github.com/TooTallNate/Java-WebSocket/blob/master/src/main/java/org/java_websocket/drafts/Draft_6455.java

Do you actively still support the nativescript-websockets lib ? Are you able to make this change?
Do you receive PRs from other people?

@NathanaelA
Copy link
Owner

@soulfly - I was unaware that the original was being maintained again. Yay! When I initially grabbed my fork of the project; I had to merge a ton of patches myself to add stability.

I love to see PR's from other people! I'll add this to my list to get updated, when I have the time.

@soulfly
Copy link
Contributor Author

soulfly commented Dec 15, 2017

Thanks @NathanaelA
I found there is already a PR which address this issue partially
#30

@soulfly
Copy link
Contributor Author

soulfly commented Dec 15, 2017

I made a separate PR
#36
also addressed one iOS related issue in it.
@NathanaelA are you able to check it?

@NathanaelA
Copy link
Owner

I have accepted and merged all pull requests and then fixed the bugs that I found from them. Thanks guys!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants