Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Add an emphasized mention to NgZone in the doc #44

Closed
gdurand opened this issue Mar 28, 2018 · 3 comments
Closed

Add an emphasized mention to NgZone in the doc #44

gdurand opened this issue Mar 28, 2018 · 3 comments

Comments

@gdurand
Copy link

gdurand commented Mar 28, 2018

I know that the tutorial mentions the problem with UI updates with Angular, but I accidentally skipped this while reading the insane amount of docs required to start a nativescript project.
I think something in bold, red and blinking about the usage of NgZone in the doc file would attract more attention and prevent people to lose so much time with non-working UI updates.

@NathanaelA
Copy link
Owner

Were you meaning to post this to the general nativescript angular repo https://github.com/NativeScript/NativeScript-angular -- Or was there something you ran into specifically with my Websocket plugin?

@gdurand
Copy link
Author

gdurand commented Mar 29, 2018

I guess it can apply to nativescript (or rather angular) in general, but it is especially relevant for this library because if you use standard nativescript libs you don't run into this kind of advanced topic (from my very limited experience).
The real issue is I didn't read properly the tutorial, but a more formal warning in the doc about using NgZone.run() in callbacks if they should trigger UI updates may help others.

@NathanaelA
Copy link
Owner

Thank you; I have added this to the next versions doc's.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants