Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude checking of a memory intersection, when add an overlay block #1376

Merged
merged 1 commit into from Jan 27, 2020
Merged

Exclude checking of a memory intersection, when add an overlay block #1376

merged 1 commit into from Jan 27, 2020

Conversation

saruman9
Copy link
Contributor

Don't check memory block for memory intersections if it's overlay when use Add To Program... action.

Fix #1375

@saruman9
Exclude checking of a memory intersection, when add an overlay block
4ef0912 
Don't check memory block for memory intersections if it's overlay when use `Add To Program...` action.

Fix NationalSecurityAgency#1375
dragonmacher
dragonmacher approved these changes Jan 24, 2020
View reviewed changes
Copy link
Collaborator

@dragonmacher dragonmacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@GhidorahRex GhidorahRex added this to the 9.2 milestone Jan 27, 2020
@GhidorahRex GhidorahRex merged commit 4ef0912 into NationalSecurityAgency:master Jan 27, 2020
@saruman9 saruman9 deleted the fix_add_overlay branch January 27, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmacher dragonmacher dragonmacher approved these changes

Assignees
No one assigned
Labels
Feature: Loader/Binary
Projects
None yet
Milestone
9.2
Development

Successfully merging this pull request may close these issues.

Don't check for memory conflict when adding an overlay memory block
4 participants
@saruman9 @dragonmacher @ryanmkurtz @GhidorahRex