Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle wrapper in the repository #455

Open
lacasseio opened this issue Apr 18, 2019 · 2 comments
Open

Add Gradle wrapper in the repository #455

lacasseio opened this issue Apr 18, 2019 · 2 comments
Assignees
Labels
Status: Internal This is being tracked internally by the Ghidra team Type: Enhancement New feature or request

Comments

@lacasseio
Copy link

Is your feature request related to a problem? Please describe.
It's not obvious which version of Gradle the project should be using as well as makes all development configuration more complicated.

Describe the solution you'd like
The Gradle wrapper should be added to the repository. For security concern, always verify the checksum of the wrapper when accepting PR that includes one.

Describe alternatives you've considered
The alternative, which is not providing a wrapper. Adds maintenance burden on the users and possibly on the team when answering questions regarding Gradle version to use. It's also the most idiomatic way of using Gradle.

Additional context
Feel free to raise any concern about using the Wrapper. The Gradle team is happy to address them.

@lacasseio
Copy link
Author

See PR: #456

@ryanmkurtz
Copy link
Collaborator

Closing for now. See comment in pull-request for more info.

@ryanmkurtz ryanmkurtz self-assigned this Apr 10, 2024
@ryanmkurtz ryanmkurtz added the Status: Internal This is being tracked internally by the Ghidra team label Apr 10, 2024
@ryanmkurtz ryanmkurtz reopened this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Internal This is being tracked internally by the Ghidra team Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants