-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ios): opaque bars break ui layout (#6929)
* fix(ios): opaque bars break ui layout * test(): change flat action bar tests * test(): revert test flat change test
- Loading branch information
1 parent
46ce866
commit 09fa085
Showing
16 changed files
with
71 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<Page xmlns="http://schemas.nativescript.org/tns.xsd" backgroundColor="yellow"> | ||
|
||
<ActionBar flat="true" backgroundColor="blue"> | ||
<Label text="flat action bar"></Label> | ||
</ActionBar> | ||
|
||
<StackLayout backgroundColor="red"> | ||
<Label text="lorem ipsum" backgroundColor="green"></Label> | ||
</StackLayout> | ||
</Page> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
<Page xmlns="http://schemas.nativescript.org/tns.xsd"> | ||
<Page xmlns="http://schemas.nativescript.org/tns.xsd" backgroundColor="yellow"> | ||
|
||
<ActionBar flat="true" backgroundColor="blue"> | ||
<Label text="flat action bar"></Label> | ||
</ActionBar> | ||
|
||
<ScrollView backgroundColor="green"> | ||
<Label text="lorem ipsum" backgroundColor="red"></Label> | ||
<ScrollView backgroundColor="red"> | ||
<Label text="lorem ipsum" backgroundColor="green"></Label> | ||
</ScrollView> | ||
</Page> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { EventData } from "tns-core-modules/data/observable"; | ||
import { TabView } from "tns-core-modules/ui/tab-view"; | ||
|
||
export function onLoaded(args: EventData) { | ||
const tabView = <TabView>args.object; | ||
tabView.ios.tabBar.translucent = false; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<Page backgroundColor="yellow"> | ||
<ActionBar flat="true" backgroundColor="blue"> | ||
<Label text="flat action bar"></Label> | ||
</ActionBar> | ||
|
||
<TabView androidTabsPosition="bottom" loaded="onLoaded"> | ||
<TabViewItem title="First"> | ||
<StackLayout backgroundColor="red"> | ||
<Label text="First View" backgroundColor="green"/> | ||
</StackLayout> | ||
</TabViewItem> | ||
</TabView> | ||
</Page> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
<Page navigatedTo="onNavigateTo" > | ||
<Page.actionBar> | ||
<ActionBar title="Flat property"/> | ||
</Page.actionBar> | ||
<StackLayout> | ||
<Page navigatedTo="onNavigateTo" backgroundColor="yellow"> | ||
|
||
<ActionBar backgroundColor="blue"> | ||
<Label text="flat action bar"></Label> | ||
</ActionBar> | ||
|
||
<StackLayout backgroundColor="red"> | ||
<Button margin="30" text="change flat property" tap="changeFlatPropertyValue"/> | ||
<Label id="flatPropertyValue" /> | ||
<Label id="flatPropertyValue" backgroundColor="green" /> | ||
</StackLayout> | ||
</Page> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters