chore: more specific native-api-usage.json file #10131

farfromrefug · 2022-12-15T16:03:17Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

nx-cloud · 2022-12-15T16:03:22Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e816919. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`nx run apps-automated:ios --timeout=600`

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

CatchABus · 2022-12-17T12:30:28Z

@farfromrefug What impact will this have for devs that use unregistered apis inside their apps?
For instance, I could make use of java.text.* (e.g. SimpleDateFormat) which I don't see there.

farfromrefug · 2022-12-17T17:55:46Z

@CatchABus yes if your app was not setting the correct native api usage from the app code it might fail now if it was "covered" by N native-api-usage. But I would not call that a regression in the sense that your app should handle that.
By the almost all community plugins set the correct native-api-usage for android. Not sure about nativescript plugins

jcassidyav · 2023-01-19T17:49:21Z

This is a tough task to test, but what I'm doing is comparing ths to what I get from running https://github.com/jcassidyav/generate-metadata-filter and comparing the gaps in each.

I haven't gone through everything but so far I have found these missing rules:

"android.content:ClipData",
"android.content:ContentResolver",
"android.graphics.drawable:StateListDrawable",
"android.webkit:URLUtil"

farfromrefug · 2023-01-20T10:11:14Z

@jcassidyav nice will add those. BTW what is the real difference between android.content:ContentResolver and android.content:ContentResolver* . From what i have tested metadata are even bigger with android.content:ContentResolver which does not really make sense to me

EDIT: it seems my old tests about * were wrong. I tested again and * behave as expected and is thus not needed here.

…ch name starts the same as one we choose to explicitly keep

jcassidyav · 2023-01-23T16:31:58Z

@farfromrefug That is great at least it makes sense.

I think though that the * were hiding another problem, e.g.

     "android.widget:ImageView",
     "android.widget.ImageView:ScaleType",

Does not allow access to android.widget.ImageView.ScaleType but this works:

     "android.widget:ImageView",
     "android.widget:ImageView.ScaleType",

I think it is
LHS = package name
RHS = class name

previously android.widget:ImageView*, was allowing the class name ImageView.ScaleType.

farfromrefug · 2023-01-23T16:37:24Z

@jcassidyav wow that is a big issue ! thanks for catching this. I was updating all my plugins with that change, might have broken stuff!

Also removed `androidx.appcompat:R.attr` as i dont think we are using it

farfromrefug · 2023-01-23T16:48:14Z

@jcassidyav i updated the file. Does that look good to you?
Also removed androidx.appcompat:R.attr as i dont think we need it

jcassidyav · 2023-01-23T17:28:38Z

@farfromrefug When I run the generator against core I get android-native-api-usage.zip.

It may be too aggressive in picking up what is required but it is picking up some rules which are definitely required, I haven’t had a chance to look at the discrepancies yet.

It is easy to spot things which are just newed up in the typescript, once they have been highlighted, but if it is the type of a parameter to something else then very difficult.

But here is one example that is required:

"android.view.accessibility:AccessibilityManager.TouchExplorationStateChangeListener",

Also "android.inputmethodservice.Keyboard:Key" should be "android.inputmethodservice:Keyboard.Key",

farfromrefug · 2023-01-23T17:51:56Z

@jcassidyav OK great i LL take a look

…or easier maintenance

… farfromrefug-patch-2

jcassidyav · 2023-02-03T11:41:41Z

@farfromrefug I was able to get the /apps/automated tests running with the usage enabled by adding:

These may be only used in the test code ( hard to tell for sure):

  "androidx.appcompat.content.res:AppCompatResources",
        "android.os:MessageQueue",
        "android.os:Message",
        "android.view:ViewGroup.MarginLayoutParams",

These are definitly used in core:

        "android.graphics:ColorFilter",
        "android.widget:TabHost.TabSpec",
        "androidx.transition:Explode",
        "java.lang:Runtime",
        "android.widget:FrameLayout.LayoutParams",
        "android.view:View.AccessibilityDelegate",
        "java.lang.reflect:Method",
        "java.lang.reflect:AccessibleObject",
        "android.widget:HorizontalScrollView",
        "androidx.core.widget:NestedScrollView",
        "android.view:WindowManager.LayoutParams",
        "android.view:WindowManager",
}

farfromrefug · 2023-02-03T12:33:18Z

@jcassidyav thanks a lot. I was adding missing by testing in my production apps. I will run the tests too!
Thanks for helping on this!

farfromrefug · 2023-02-06T14:31:07Z

@jcassidyav
about android.graphics:ColorFilter i dont think we need it. We only use getColorFilter in the tests and setColorFilter is only used with a color.

"android.widget:FrameLayout.LayoutParams", i dont see where it is used. We use CommonLayoutParams which inherits android.widget.FrameLayout.LayoutParams but we dont actually use any method from android.widget.FrameLayout.LayoutParams

"java.lang.reflect:AccessibleObject", i dont think we use that class. we use java.lang.reflect.Field which inherits java.lang.reflect:AccessibleObject but we dont seem to be needing to marshall it. Though we do use it in the tests!

"android.widget:HorizontalScrollView" we use a class inheriting this but i dont think we need the methods from that parent class

"android.view:WindowManager.LayoutParams","android.view:WindowManager", cant find where we use those. Do you know?

jcassidyav · 2023-02-07T12:06:45Z

@farfromrefug

java.lang.reflect:AccessibleObject from my tests is required because we call setAccessible.
android.widget:HorizontalScrollView smoothScrollTo is called.
android.view:WindowManager.LayoutParams comes from here
android.graphics:ColorFilter I think you are correct I didn't look closely at what the params to setColorFilter were.

The others, you are probably correct also, the tests fall apart so completly I thought they were used in core. That said for a small cost maybe they are worth keeping to let the tests run?

farfromrefug · 2023-02-07T13:21:26Z

@jcassidyav smoothScrollTo you are right! HorizontalScrollView does NOT inherite NestedScrollView1
java.lang.reflect:AccessibleObject you are right too used by list-picker!
android.view:WindowManager.LayoutParams i just tested and that line works without android.view:WindowManager.LayoutParams. The reason is that the softInputMode returns an int even if it is part of android.view:WindowManager.LayoutParams. So the getter + setter will work

About the test ones i actually added them to the apps App_Resources so we should not need to add them to the core.

As a note on what all that can do, i pushed metadata filtering + proguard to its best (might even do better):

use very detailed whitelist for N and plugins
use whitelist to auto generate proguard file
added and use a new custom field proguard_blacklist to my app native-api-usage.json which i use to tell gradle which classes it can fully remove
The result are those:
without native-api-usage/gradle: 18.4mb apk and 2900ms app cold start(lowest)
with native-api-usage/gradle: 14.4mb apk and 2700ms app cold start(lowest)

Seems to me it is worse going as detailed as possible

jcassidyav · 2023-02-07T13:45:50Z

@farfromrefug Strange, I get
Caused by: java.lang.NoSuchMethodError: no non-static method "Landroid/view/Window;.getAttributes()Landroid/view/ViewGroup$LayoutParams;"

when calling getAttributes() on a window without specifying android.view:WindowManager.LayoutParams in the usage

farfromrefug · 2023-02-07T17:32:59Z

@jcassidyav indeed weird I will investigate. Thanks !

farfromrefug · 2023-02-22T13:06:14Z

@jcassidyav i added all the fixes we talked about. Even android.view:WindowManager.LayoutParams cause even though it does not crash here, your explanation makes sense

chore: more specific native-api-usage.json file

5f73d20

cla-bot bot added the cla: yes label Dec 15, 2022

NathanWalker added this to the 8.5 milestone Dec 21, 2022

NathanWalker added the breaking-change label Dec 21, 2022

farfromrefug and others added 2 commits January 20, 2023 11:14

Update native-api-usage.json

eb73b8b

chore: it is actually better not to use *. It will filter classes whi…

9eb8487

…ch name starts the same as one we choose to explicitly keep

fix(android): native-api-usage fix after last changes

bcc7513

Also removed `androidx.appcompat:R.attr` as i dont think we are using it

Merge branch 'main' into farfromrefug-patch-2

e84d186

farfromrefug added 5 commits January 24, 2023 10:11

fix(android): fixed native-api-usage after removing "*". And sorted f…

d2b6847

…or easier maintenance

chore: missed for native-api-usage

7bd9c09

fix(core): android native-api-usage fix

a369364

Merge remote-tracking branch 'nativescript/farfromrefug-patch-2' into…

8727c25

… farfromrefug-patch-2

fix(core): android native-api-usage fix

51b77fd

fix(core): native-api-usage fixes

866f444

fix(core): improved native-api-usage

e816919

NathanWalker modified the milestones: 8.5, 9.0 Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: more specific native-api-usage.json file #10131

chore: more specific native-api-usage.json file #10131

farfromrefug commented Dec 15, 2022

nx-cloud bot commented Dec 15, 2022 •

edited

CatchABus commented Dec 17, 2022 •

edited

farfromrefug commented Dec 17, 2022

jcassidyav commented Jan 19, 2023

farfromrefug commented Jan 20, 2023 •

edited

jcassidyav commented Jan 23, 2023

farfromrefug commented Jan 23, 2023

farfromrefug commented Jan 23, 2023

jcassidyav commented Jan 23, 2023

farfromrefug commented Jan 23, 2023

jcassidyav commented Feb 3, 2023

farfromrefug commented Feb 3, 2023

farfromrefug commented Feb 6, 2023

jcassidyav commented Feb 7, 2023 •

edited

farfromrefug commented Feb 7, 2023 •

edited

jcassidyav commented Feb 7, 2023

farfromrefug commented Feb 7, 2023

farfromrefug commented Feb 22, 2023

chore: more specific native-api-usage.json file #10131

Are you sure you want to change the base?

chore: more specific native-api-usage.json file #10131

Conversation

farfromrefug commented Dec 15, 2022

PR Checklist

What is the current behavior?

What is the new behavior?

nx-cloud bot commented Dec 15, 2022 • edited

☁️ Nx Cloud Report

CatchABus commented Dec 17, 2022 • edited

farfromrefug commented Dec 17, 2022

jcassidyav commented Jan 19, 2023

farfromrefug commented Jan 20, 2023 • edited

jcassidyav commented Jan 23, 2023

farfromrefug commented Jan 23, 2023

farfromrefug commented Jan 23, 2023

jcassidyav commented Jan 23, 2023

farfromrefug commented Jan 23, 2023

jcassidyav commented Feb 3, 2023

farfromrefug commented Feb 3, 2023

farfromrefug commented Feb 6, 2023

jcassidyav commented Feb 7, 2023 • edited

farfromrefug commented Feb 7, 2023 • edited

jcassidyav commented Feb 7, 2023

farfromrefug commented Feb 7, 2023

farfromrefug commented Feb 22, 2023

nx-cloud bot commented Dec 15, 2022 •

edited

CatchABus commented Dec 17, 2022 •

edited

farfromrefug commented Jan 20, 2023 •

edited

jcassidyav commented Feb 7, 2023 •

edited

farfromrefug commented Feb 7, 2023 •

edited