Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve loaded/unloaded handling to be stable and consistent #10170

Merged
merged 4 commits into from Jan 16, 2023

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Jan 15, 2023

PR Checklist

What is the current behavior?

Various TypeErrors, crashes and unstable behavior would result from inconsistent handling of loaded/unloaded events.
For example, a ListView bound to an Array where the items were programmatically changed which would fire a render of the list would cause undefined errors due to unloaded firing on a TextField tearing down the delegate used inside.

What is the new behavior?

These conditions are now stable and more performant due to unnecessary repetitive setup/teardown.

@nx-cloud
Copy link

nx-cloud bot commented Jan 15, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0ed42a1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

triniwiz
triniwiz previously approved these changes Jan 16, 2023
Copy link
Member

@triniwiz triniwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@NathanWalker NathanWalker merged commit c9e29aa into main Jan 16, 2023
@NathanWalker NathanWalker deleted the fix/unloaded-delegate-handling branch January 16, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants