fix(core): RootLayout view and shade cover should animate in parallel #10256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
RootLayout view and shade cover don't animate in parallel.
What is the new behavior?
This fixes animation problems caused by #10228, makes few of checks more obvious, and adds a bit more of a missing promise functionality for method
openShadeCover
.BREAKING CHANGES:
Method
openShadeCover
return type changes fromvoid
toPromise<void>
.