Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): RootLayout view and shade cover should animate in parallel #10256

Merged

Conversation

CatchABus
Copy link
Contributor

PR Checklist

What is the current behavior?

RootLayout view and shade cover don't animate in parallel.

What is the new behavior?

This fixes animation problems caused by #10228, makes few of checks more obvious, and adds a bit more of a missing promise functionality for method openShadeCover.

BREAKING CHANGES:

Method openShadeCover return type changes from void to Promise<void>.

@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6e080c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla: yes label Mar 29, 2023
@CatchABus CatchABus marked this pull request as draft March 29, 2023 21:05
@NathanWalker
Copy link
Contributor

This is looking good @CatchABus thanks for handling 🤗

@CatchABus CatchABus marked this pull request as ready for review April 2, 2023 17:42
@NathanWalker NathanWalker merged commit 2b64e17 into NativeScript:main Apr 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants