Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transitions): support zIndex on ios shared elements + support page props on android #10261

Merged
merged 17 commits into from Apr 17, 2023

Conversation

NathanWalker
Copy link
Contributor

PR Checklist

What is the current behavior?

Visual ordering of shared elements would occur at random often. Also Android pageEnd props would not be considered.

What is the new behavior?

This allows zIndex to be set if a specified visual stacking order is preferred during the transition. This also allows Android pageEnd props to be considered.

@nx-cloud
Copy link

nx-cloud bot commented Apr 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7f48bc6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla: yes label Apr 2, 2023
@NathanWalker NathanWalker force-pushed the fix/transitions-misc branch 2 times, most recently from e855fad to d9050a0 Compare April 12, 2023 15:57
@NathanWalker NathanWalker marked this pull request as ready for review April 12, 2023 17:33
@NathanWalker NathanWalker merged commit f4b2722 into main Apr 17, 2023
1 of 2 checks passed
@NathanWalker NathanWalker deleted the fix/transitions-misc branch April 17, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants