Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger css update when setting root classes #10328

Merged
merged 2 commits into from Jun 23, 2023

Conversation

rigor789
Copy link
Member

PR Checklist

What is the current behavior?

In some scenarios setting the initial root css classes doesn't trigger a style update.

What is the new behavior?

We force update styling whenever setting root css classes.

fixes #10318

@nx-cloud
Copy link

nx-cloud bot commented Jun 23, 2023

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

We didn't find any information for the current pull request with the commit d6108d6.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla: yes label Jun 23, 2023
@NathanWalker NathanWalker merged commit 0903719 into main Jun 23, 2023
1 of 3 checks passed
@NathanWalker NathanWalker deleted the fix/root-class-css-change branch June 23, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS only: Broken CSS classes when .ns-root is used. Core 8.5.4, 8.5.5, 8.5.6 (8.5.3 is working correctly)
2 participants