fix(testing): e2e flag no longer needed, testID is now applicable in dev or prod builds #10396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
--env.e2e
that enablestestID
and blocks accessibility features before building for testing. Passing this argument is needed becauseView.setContentDescription
method which is also used by TalkBack to announce items is also used intestID
property's Android implementation to store the view identifier.What is the new behavior?
AccessibilityNodeInfo.setViewIdResourceName
is used to set resource id instead ofView.setContentDescription
that sets content description on Android.--env.e2e
anymore. So the production builds can now be tested.accessibilityIdentifier
will be the source of truth. SettingtestID
property will also setaccessibilityIdentifier
. But settingaccessibilityIdentifier
property will updatetestID
only if there is atestID
already set and has a different value.