Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Add/remove shadow for reusable views #10409

Merged
merged 2 commits into from Oct 14, 2023

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Oct 14, 2023

PR Checklist

What is the current behavior?

When it comes to reusable views, it seems that view box shadow is not removed when view gets removed from view tree.
That is because shadow layer belongs to parent and we rely on disposeNativeView to cleanup shadows but that doesn't seem to be the right approach.

What is the new behavior?

Add/remove shadows along with view, regardless of being reusable or not. It's also a good replacement for my previous PR.

@cla-bot cla-bot bot added the cla: yes label Oct 14, 2023
@NathanWalker NathanWalker merged commit ee87b52 into NativeScript:main Oct 14, 2023
1 of 2 checks passed
tdermendjiev pushed a commit to tdermendjiev/NativeScript that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants