Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Do not try to rehydrate destroyed dialogs #10414

Merged
merged 2 commits into from Oct 24, 2023

Conversation

jcassidyav
Copy link
Contributor

PR Checklist

What is the current behavior?

If a Dialog is currently being shown, and the app is sent to the background where the Activity is then destroyed, when the app is brought to the foreground the app will crash.

This is because when the activity is destroyed, the dialog is torn down, but this happens after state is saved and it crashes when the dialog is being restored.

( Easy to test by turning on the Don't keep activities developer option. )

What is the new behavior?

The change is to cancel the dialog creation if being restored in a state where the creation of the dialog will crash.

@cla-bot cla-bot bot added the cla: yes label Oct 18, 2023
@NathanWalker NathanWalker merged commit 7563549 into NativeScript:main Oct 24, 2023
1 of 2 checks passed
tdermendjiev pushed a commit to tdermendjiev/NativeScript that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants