fix(android): Do not try to rehydrate destroyed dialogs #10414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
If a Dialog is currently being shown, and the app is sent to the background where the Activity is then destroyed, when the app is brought to the foreground the app will crash.
This is because when the activity is destroyed, the dialog is torn down, but this happens after state is saved and it crashes when the dialog is being restored.
( Easy to test by turning on the
Don't keep activities
developer option. )What is the new behavior?
The change is to cancel the dialog creation if being restored in a state where the creation of the dialog will crash.