Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): ScrollView with listeners removed scroll delegate #10432

Merged
merged 2 commits into from Nov 22, 2023

Conversation

CatchABus
Copy link
Contributor

PR Checklist

What is the current behavior?

There are cases when attempting to remove a listener callback that does not exist breaks scroll event of ScrollView.

What is the new behavior?

We follow the same principle with Span overrides and check the existence of listeners. This gives better control and gets rid of problems like the one described above.

Fixes #10431.

@NathanWalker NathanWalker merged commit 9fae9c4 into NativeScript:main Nov 22, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollview does not fire scroll events when background color is set
2 participants