New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wepback): custom `buildPath`support #10477

Merged

rigor789 merged 3 commits into main from feat/webpack-custom-buildpath

Jan 19, 2024

Member

rigor789 commented Jan 19, 2024

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Replaces and closes #10452

farfromrefug and others added 2 commits

November 30, 2023 16:48


          feat(wepback): support custom buildPath through nativescript.config

68383e2

needs a PR on @nativescript/cli


          chore: cleanup

2204a91

cla-bot bot added the cla: yes label


          fix: use nullish coalescing

4d8cc8e

rigor789 merged commit 4293284 into main

1 of 3 checks passed

rigor789 deleted the feat/webpack-custom-buildpath branch

January 19, 2024 19:23

Contributor

vallemar commented Jan 20, 2024

@rigor789 This should be added here https://docs.nativescript.org/configuration/webpack#additional-flags or here https://docs.nativescript.org/project-structure/nativescript-config? or in both?

Collaborator

farfromrefug commented Mar 2, 2024

@rigor789 could we get a release with this? (i dont think there is one). I have contributors who need this).
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment