Fixes: #2796 - ActionItems lacks proper support for VoiceOver on iOS #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er on iOS UIBarButtonItem weren't created with a title/text so VoiceOver couldn't know what to reads. This marks the element as an AccessibilityElement and sets an accessibilityLabel.
|
Can one of the admins verify this patch? |
|
run ci |
|
uitests |
vchimev
reviewed
Sep 29, 2016
|
LGTM 👍 |
vakrilov
approved these changes
Oct 5, 2016
hshristov
approved these changes
Oct 5, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2796 - ActionItems lacks proper support for VoiceOver on iOS
The
UIBarButtonItemelement wasn't always created with a title/text soVoiceOvercouldn't know what to read for the user.This PR marks the element as an
AccessibilityElementand sets the accessibilityLabel to the title/text if one is set.I've chosen to mark the
UIBarButtonItemwith justUIAccessibilityTraitButton-trait, because I see it as the most general trait I could set.