Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyChange for TimePicker in CLOCK mode not working on Android 5 Lolipop #2940

Closed
NickIliev opened this issue Oct 21, 2016 · 5 comments
Closed
Assignees

Comments

@NickIliev
Copy link
Contributor

Dependency observable properties hour and minute are not working under Android 5 (working for Android 4.4 and Android 6 & 7 thou)
Code to reproduce here or:

AndroidManifext.xml

<!-- Default style for TimePicker - in spinner mode -->
<style name="SpinnerTimePicker" parent="android:Widget.Material.Light.TimePicker">
    <item name="android:timePickerMode">clock</item>
</style>

page.xml

<TimePicker id="tp" hour="{{ hour }}" minute="{{ minute }}" propertyChange="onChange"></TimePicker>

page.ts

export function onCheckChange(args:PropertyChangeData) {
    console.log(args.eventName);
    console.log(args.object);
    console.log(args.propertyName);
    console.log(args.value);
}

Related to #2901

@hamorphis
Copy link
Contributor

@hamorphis
Copy link
Contributor

@hamorphis
Copy link
Contributor

This issue is fixed with Android version 5.1 (API Level 22). The only broken version seems to be Android 5.0 (API Level 21). So we can't really fix anything in Nativescirpt. The bad news is that you cannot change the time picker mode to spinner programmatically: http://stackoverflow.com/questions/27277338/android-how-to-programmatically-change-timepicker-mode

@odubuc
Copy link

odubuc commented Oct 31, 2016

Alright thanks I didn't think looking for issues in Android itself... (sorry about that)
In that case I'll revert to spinner, there is too much 5.0 in use.

@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants