Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ripple effect lost on Segmented-Bar with selectedBackgroundColor #3137

Closed
bradmartin opened this issue Nov 21, 2016 · 4 comments 路 Fixed by #3143
Closed

Ripple effect lost on Segmented-Bar with selectedBackgroundColor #3137

bradmartin opened this issue Nov 21, 2016 · 4 comments 路 Fixed by #3143
Assignees
@SvetoslavTsenov @enchev
Labels
bug done os: android
Milestone
2.5.0

Comments

@bradmartin
Copy link
Contributor

bradmartin commented Nov 21, 2016 •
edited

NS 2.4 all
Using selectedBackgroundColor will lose the ripple effect. Tested on Android 6.0
This issue with the button fix many versions ago might help in fixing. #1296

CC: @enchev - you might remember this better than anyone 馃槃

Good

<SegmentedBar>
            <SegmentedBar.items>
                <SegmentedBarItem title="Yesterday" />
                <SegmentedBarItem title="Today" />
                <SegmentedBarItem title="Tomorrow" />
            </SegmentedBar.items>
        </SegmentedBar>

Broken

 <SegmentedBar selectedBackgroundColor="red">
            <SegmentedBar.items>
                <SegmentedBarItem title="Yesterday" />
                <SegmentedBarItem title="Today" />
                <SegmentedBarItem title="Tomorrow" />
            </SegmentedBar.items>
        </SegmentedBar>

segbarbug
@bradmartin
Copy link
Contributor Author

I'll update the .gif later, gotta downgrade licecap on mac 馃槥

@bradmartin
Copy link
Contributor Author

segbarbug

@enchev
Copy link
Contributor

enchev commented Nov 22, 2016

Thanks @bradmartin! We will fix this immediately!

@enchev enchev added the bug label Nov 22, 2016
@enchev enchev mentioned this issue Nov 22, 2016
Merged
@enchev enchev added this to the 2.5.0 milestone Nov 22, 2016
@enchev enchev self-assigned this Nov 22, 2016
@SvetoslavTsenov SvetoslavTsenov self-assigned this Nov 22, 2016
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SvetoslavTsenov SvetoslavTsenov

@enchev enchev

Labels
bug done os: android
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

setColorFilter used if android.os.Build.VERSION.SDK_INT >= 21 NativeScript/NativeScript
4 participants
@SvetoslavTsenov @enchev @bradmartin @NickIliev