Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Slide page transition causes "snap" behaviour #3775

Closed
josempbrites opened this issue Mar 10, 2017 · 7 comments
Closed

iOS Slide page transition causes "snap" behaviour #3775

josempbrites opened this issue Mar 10, 2017 · 7 comments

Comments

@josempbrites
Copy link

Hi guys,

Tell us about the problem

Since the latest update I'm having an issue when I set actionBar navigationBar.translucent = false; and remove the border. Is was working fine before, but now the page navigation and transitions are making a strange snap animation, as if, when the view loads it starts behind the actionbar.

Any ideas on what's going on? Can you test this?

Which platform(s) does your issue occur on?

iOS

Please provide the following version numbers that your issue occurs with:

  • CLI: 2.5.2
  • Cross-platform modules: 2.5.1
  • Runtime(s): iOS 2.5.0

Please tell us how to recreate the issue in as much detail as possible.

Adding the code bellow to a pageLoad event. It only happens when navigating to a details view for example.

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

if (platform.isIOS) {
        var navigationBar = frameModule.topmost().ios.controller.navigationBar;
        navigationBar.barStyle = 1;
        navigationBar.translucent = false;
        navigationBar.setBackgroundImageForBarMetrics(UIImage.new(), UIBarMetrics.Default);
        navigationBar.shadowImage = UIImage.new();   
       }
@NickIliev
Copy link
Contributor

@josempbrites can you elaborate a bit more?
I've tested the described scenario with this sample project but was not able to reproduce a "snap" behavior.

Please share with us a sample code that reproduces this case or provide more details on what transactions you are using, is your page using ActionBar and all that could help us investigate further.

@josempbrites
Copy link
Author

@NickIliev Thank you for your time. I've figured out what was the issue based on your sample project. The problem was not related with the ActionBar, but with the transition. I'm using a slide transition (not the flip transition you used).

You can try and change the transition to slide, to see what was my problem.

I've removed the transition and now the navigation behaves as it should. The slide transition would come in handy in some cases though.

@NickIliev NickIliev added bug and removed question labels Mar 14, 2017
@NickIliev NickIliev changed the title ActionBar iOS translucent=false messing up transitions iOS Slide page transition causes "snap" behaviour Mar 14, 2017
@NickIliev
Copy link
Contributor

@josempbrites thank you for the follow-up! I was able to reproduce the issue using slide transition.
Indeed in iOS, there is a strange overlapping during the animation. Logged this one as a bug.

Steps to reproduce:

  • use this test project
  • navigate from main page to sub page with slide transition - there is an overlapping in the top part of the screen around the ActionBar (the actual bug)
  • navigate back with another transition (e.g. flip) - everything works as expected

@NickIliev NickIliev added this to the 3.0 milestone Mar 14, 2017
@NickIliev NickIliev added the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Mar 14, 2017
@NickIliev
Copy link
Contributor

Similar behaviour reported here

@SvetoslavTsenov SvetoslavTsenov self-assigned this Apr 19, 2017
@SvetoslavTsenov SvetoslavTsenov added done and removed ready for test TSC needs to test this and confirm against live production apps and automated test suites labels Apr 24, 2017
@SvetoslavTsenov SvetoslavTsenov removed their assignment Apr 24, 2017
@uzarsalan
Copy link

Hi! i have the same problem with TNS v3.2.0. Is anybody has this bug?

@7ammer
Copy link

7ammer commented Apr 26, 2018

This seems similar to what is described? nativescript-vue/nativescript-vue#200

@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants