fix(slider): correct maxValue setter for android #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
force-pushed
the
vlaeva/slider-max-val
branch
from
7edeac3
to
6832597
Compare
The setter should invoke setNativeValuesSilently with the new value and max value respectively. fixes #4343
sis0k0
force-pushed
the
vlaeva/slider-max-val
branch
from
6832597
to
e4a96cd
Compare
|
run uitests |
hshristov
approved these changes
Jun 9, 2017
|
run uitests |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setter should invoke setNativeValuesSilently with the new value and the new
max value respectively.
fixes #4343