Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Keep nativeViews when navigating forward #4808

Closed
hshristov opened this issue Sep 7, 2017 · 1 comment
Closed

[Android] Keep nativeViews when navigating forward #4808

hshristov opened this issue Sep 7, 2017 · 1 comment

Comments

@hshristov
Copy link
Contributor

When navigating forward through page.frame.navigate method we are destroying nativeViews. With this change we will no longer destroy nativeViews so this will make backward navigation faster. It will also improve forward navigation because we won't do anything with the current page.

Side changes done because of this feature:

  • As there is no API to get the default animation we are using reflection once in order to extract the default animator from resources.
  • When navigating without animation we create animation with duration 0
  • We now always wait for animation completion even if the default or no animation is used (because of the above changes)
  • Simplified and refactored navigation & transition classes
  • Removed cycling module dependency

All these should produce more fluid navigation between pages in both directions.

@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants