Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw if global css file is not found in webpack context #5186

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Dec 18, 2017

Catching the error will prevent bundling with snapshot to fail with:

com is not defined

@ghost ghost assigned sis0k0 Dec 18, 2017
@ghost ghost added the in progress label Dec 18, 2017
@sis0k0
Copy link
Contributor Author

sis0k0 commented Feb 19, 2018

test

4 similar comments
@sis0k0
Copy link
Contributor Author

sis0k0 commented Feb 20, 2018

test

@sis0k0
Copy link
Contributor Author

sis0k0 commented Feb 23, 2018

test

@SvetoslavTsenov
Copy link
Contributor

test

@sis0k0
Copy link
Contributor Author

sis0k0 commented Feb 28, 2018

test

@sis0k0 sis0k0 changed the title refactor: throw if global css file is not found in webpack context fix: throw if global css file is not found in webpack context Mar 1, 2018
@sis0k0 sis0k0 merged commit 9ce0819 into master Mar 1, 2018
@ghost ghost removed the in progress label Mar 1, 2018
@sis0k0 sis0k0 deleted the vlaeva/load-css-throw branch March 1, 2018 09:05
@sis0k0 sis0k0 added this to the 4.0 milestone Mar 1, 2018
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants