Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios-action-bar): NavigationButton cannot be hidden #5451

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

ADjenkov
Copy link
Contributor

@ADjenkov ADjenkov commented Feb 22, 2018

The problem: Cannot hide back button when navigating between pages with transition. The problem occurs because of the native fade-in/fade-out animation of the back button.

The solution: Disable back button animation when transitioning between pages. Animation should occurs only on manual NavigationButton visibility change

Fix #5406
Fix NativeScript/nativescript-angular#1194

@ADjenkov ADjenkov added this to the 4.0 milestone Feb 22, 2018
@ADjenkov ADjenkov self-assigned this Feb 22, 2018
@ghost ghost added the in progress label Feb 22, 2018
@vakrilov vakrilov merged commit c54e069 into master Feb 26, 2018
@vakrilov vakrilov deleted the djenkov/ios-back-button branch February 26, 2018 07:45
@ghost ghost removed bug in progress labels Feb 26, 2018
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue NavigationButton cannot be hiden [iOS] Navigation back button appears when the app reloads or refresh
2 participants