feat(ios-list-view): introduce iosEstimatedRowHeight property. #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
manoldonev
reviewed
Mar 21, 2018
| @@ -340,7 +340,7 @@ export class ListView extends ListViewBase { | |||
| return height; | |||
| } | |||
|
|
|||
| return DEFAULT_HEIGHT; | |||
| return this.ios.estimatedRowHeight; | |||
There was a problem hiding this comment.
It seems within the class we are using this._ios vs this.ios.
manoldonev
approved these changes
Mar 21, 2018
ADjenkov
force-pushed
the
djenkov/list-view-measure
branch
from
7a9673d
to
7dea760
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iosEstimatedRowHeightproperty sets estimatedRowHeight of the UITableView which forces the ListView to auto-measure its items.Setting
iosEstimatedRowHeight="0"can easily resolve issue